From d424ac3ddf2cd6caac02f6a22f559f3a35c2a2c8 Mon Sep 17 00:00:00 2001 From: Marco Fugaro <marco.fugaro@gmail.com> Date: Wed, 20 Jun 2018 19:12:04 +0200 Subject: [PATCH 1/4] Fix error with formatWebpackMessage trimming warnings --- packages/react-dev-utils/formatWebpackMessages.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js index f1506298c..18004589a 100644 --- a/packages/react-dev-utils/formatWebpackMessages.js +++ b/packages/react-dev-utils/formatWebpackMessages.js @@ -26,6 +26,11 @@ function isLikelyASyntaxError(message) { function formatMessage(message, isError) { var lines = message.split('\n'); + // Remove the useless Module Warning message webpack sometimes outputs + if (lines.length > 2 && lines[1].indexOf('Module Warning') !== -1) { + lines.splice(1, 1); + } + if (lines.length > 2 && lines[1] === '') { // Remove extra newline. lines.splice(1, 1); -- GitLab From 3a1ffb69d48543aaaec54faff90fa6426a518b71 Mon Sep 17 00:00:00 2001 From: Marco Fugaro <marco.fugaro@gmail.com> Date: Thu, 28 Jun 2018 13:07:05 +0200 Subject: [PATCH 2/4] Check also for Module Error --- packages/react-dev-utils/formatWebpackMessages.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js index 18004589a..ea59d4df6 100644 --- a/packages/react-dev-utils/formatWebpackMessages.js +++ b/packages/react-dev-utils/formatWebpackMessages.js @@ -26,8 +26,12 @@ function isLikelyASyntaxError(message) { function formatMessage(message, isError) { var lines = message.split('\n'); - // Remove the useless Module Warning message webpack sometimes outputs - if (lines.length > 2 && lines[1].indexOf('Module Warning') !== -1) { + // Remove the useless Module Warning or Module Error message webpack sometimes outputs + if ( + lines.length > 2 && + (lines[1].indexOf('Module Warning') !== -1 || + lines[1].indexOf('Module Error') !== -1) + ) { lines.splice(1, 1); } -- GitLab From 31116d3859886c6e7e9848a11be856cf0b9e6b6a Mon Sep 17 00:00:00 2001 From: Marco Fugaro <marco.fugaro@gmail.com> Date: Tue, 10 Jul 2018 11:05:44 +0200 Subject: [PATCH 3/4] Add thread loader test in formatWebpackMessages --- packages/react-dev-utils/formatWebpackMessages.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js index ea59d4df6..d5420b5c3 100644 --- a/packages/react-dev-utils/formatWebpackMessages.js +++ b/packages/react-dev-utils/formatWebpackMessages.js @@ -26,11 +26,13 @@ function isLikelyASyntaxError(message) { function formatMessage(message, isError) { var lines = message.split('\n'); - // Remove the useless Module Warning or Module Error message webpack sometimes outputs + // Remove the useless Module Warning or Module Error message webpack sometimes outputs, + // it interferes with the thread loader stack clipping of the next few lines if ( lines.length > 2 && (lines[1].indexOf('Module Warning') !== -1 || - lines[1].indexOf('Module Error') !== -1) + lines[1].indexOf('Module Error') !== -1 || + /thread.loader/i.test(lines[1])) ) { lines.splice(1, 1); } -- GitLab From fdcdd9a62440838d4cfcc606f4851227fceaa51c Mon Sep 17 00:00:00 2001 From: Marco Fugaro <marco.fugaro@gmail.com> Date: Tue, 10 Jul 2018 12:06:52 +0200 Subject: [PATCH 4/4] Remove other thread-loader noise in formatWebpackMessages --- packages/react-dev-utils/formatWebpackMessages.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js index d5420b5c3..91e31b4fd 100644 --- a/packages/react-dev-utils/formatWebpackMessages.js +++ b/packages/react-dev-utils/formatWebpackMessages.js @@ -37,8 +37,13 @@ function formatMessage(message, isError) { lines.splice(1, 1); } + // Remove other thread-loader noise + if (lines.length > 2 && /thread.loader/i.test(lines[1])) { + lines.splice(1, 1); + } + + // Remove extra newline. if (lines.length > 2 && lines[1] === '') { - // Remove extra newline. lines.splice(1, 1); } -- GitLab