Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4678

Fix CI error (kitchensink)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Brew-Brew/mynext2 into next 7 years ago
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: Brew-Brew

#4635 (closed) i referenced this issue

  1. i fixed ci error by version up jsdom. i found kichensink's jsdom version was outdated(9.8.3). so I versioned up to latest what can fix ci error

(after jsdom 11.6.0, Error: Could not parse CSS stylesheet issue was solved) I referenced this url. By this issue fixed, jsdom was version up. so i resolved error by version up jsdom :) https://github.com/jsdom/jsdom/issues/2131

  1. when i fixed #4635 (closed) i found latest jsdom has TypeError: jsdom.createVirtualConsole is not a function(deprecated) error, so i referenced https://github.com/jsdom/jsdom/issues/1820, i solved the issue.
Loading
Loading

Activity


  • Administrator added CLA Signed label 7 years ago

    added CLA Signed label

  • Administrator mentioned in issue #4635 (closed) 7 years ago

    mentioned in issue #4635 (closed)

  • Administrator changed title from Fix CI error by version up jsdom (kitchensink) to Fix CI Fail error by version up jsdom (kitchensink) 7 years ago

    changed title from Fix CI error by version up jsdom (kitchensink) to Fix CI Fail error by version up jsdom (kitchensink)

  • Administrator changed title from Fix CI Fail error by version up jsdom (kitchensink) to Fix CI error by version up jsdom (kitchensink) 7 years ago

    changed title from Fix CI Fail error by version up jsdom (kitchensink) to Fix CI error by version up jsdom (kitchensink)

  • Administrator changed title from Fix CI error by version up jsdom (kitchensink) to Fix CI error (Error: Could not parse CSS stylesheet) by version up jsdom (kitchensink) 7 years ago

    changed title from Fix CI error by version up jsdom (kitchensink) to Fix CI error (Error: Could not parse CSS stylesheet) by version up jsdom (kitchensink)

  • Administrator changed title from Fix CI error (Error: Could not parse CSS stylesheet) by version up jsdom (kitchensink) to Fix CI error (kitchensink) 7 years ago

    changed title from Fix CI error (Error: Could not parse CSS stylesheet) by version up jsdom (kitchensink) to Fix CI error (kitchensink)

  • Administrator changed title from Fix CI error (kitchensink) to Fix CI error by version up jsdom (kitchensink) 7 years ago

    changed title from Fix CI error (kitchensink) to Fix CI error by version up jsdom (kitchensink)

  • Administrator changed title from Fix CI error by version up jsdom (kitchensink) to Fix CI error (kitchensink) 7 years ago

    changed title from Fix CI error by version up jsdom (kitchensink) to Fix CI error (kitchensink)

  • Administrator
    Administrator @root · 7 years ago
    Author Contributor

    Created by: bugzpodder

    Just FYI your test run still has Could not parse spreadsheet error in Travis: https://travis-ci.org/facebook/create-react-app/jobs/396507343#L2870 https://travis-ci.org/facebook/create-react-app/jobs/396507338#L2164

    I've created an earlier PR here that just imported smaller CSS files that didn't give this error message: http://metis.lti.cs.cmu.edu:8023/facebook/create-react-app/-/merge_requests/4550

    I think try/catch when requiring jsdom is unnecessary

  • Administrator
    Administrator @root · 7 years ago
    Author Contributor

    Created by: Brew-Brew

    Ah ha! I got it! Contribute to open source is so hard.... :(

  • Administrator
    Administrator @root · 7 years ago
    Author Contributor

    Created by: Brew-Brew

    Thanks!

  • Administrator closed 7 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: Ruby Feature: OAS 3.0 spec support
2
Client: Ruby Feature: OAS 3.0 spec support
    Assign labels
  • Manage project labels

Milestone
5.0.0
5.0.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: OpenAPITools/openapi-generator!7415
Source branch: github/fork/Brew-Brew/mynext2

Menu

Explore Projects Groups Snippets