Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4758

Use same executable for spawn as the current process

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/mgit-at/keep-same-node-executable into next Jul 09, 2018
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: gimpf

When starting a react-script from a node process which is not in the path, the scripts would spawn the wrong node executable, or even fail. This can happen when starting node with an absolute path, for instance in a Bazel build.

Changes verified by both creating a new project, building and running it, and also by applying the same changes in another internal project -- this fixed our Bazel build issue.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mgit-at/keep-same-node-executable