Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4813

Add BUILD_DIR env variable to configure name for build output directory

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/DanProudfoot/next into next Jul 23, 2018
  • Overview 5
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: DanProudfoot

Hi there

This is my first pull request for anything, I think, so let me know if I'm breaking protocol.

I'm not exactly hot on Node backend stuff really, but the intention here was to allow the build directory to be set to anything (excluding a few reserved names like public, src, .git and node_modules).

My rationale came from doing a bit of Cordova development, where the web files are expected to be in a 'www' folder instead of 'build'

I have tested this myself that it outputs files into the specified folder, and it will throw an error if the path is forbidden.

I don't know what to do re: adding real tests, but I'm willing to take pointers

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/DanProudfoot/next