Change severity of no-restricted-globals to warn

Created by: silverwind

Sometimes, it is intended to access browser globals like location, so we change the severity of this rule to warn which allows the app to still start in presence of such an lint issue.

Created by: facebook-github-bot

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

added CLA Signed label

Created by: facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Created by: Timer

You can access this by prefixing the variable with window, we're not gonna be changing this.

Thanks for the PR though!

closed

Created by: silverwind

Yes, I knew about prefixing with window, but I think it is uneccessarily noisy to do so.

we're not gonna be changing this

Why thought? It's certainly not an "error" to access thing like location.pathname, is it? To me, this seems like a very opinionated configuration, certainly not "minimal" as describted in the docs.

Created by: Timer

See the motivations on the package.