Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4930

Switch from cheap-module-source-map eval-source-map

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jasonLaster/source-map into next Aug 27, 2018
  • Overview 15
  • Commits 1
  • Pipelines 0
  • Changes 5

Created by: jasonLaster

Fixes issue

Switches webpack's devtool mode from cheap-module-source-map to source-map so that the mappings include column positions.

This enables variable and scope mappings in Firefox, which makes it easier to debug applications built with webpack and babel. This should fix the this mapping issue. It will also simplify the scopes pane by showing the "original" scopes and variables. It will also enable in-line code preview and console support when evaluating "original" expressions.

The incremental build times were 25% slower for source-map vs cheap-module-source-maps (500ms vs 400ms) on a simple app. I believe that webpack's cache means that these numbers would not be that different on a larger app.

Both modes had equivalent breakpoint support on page load and while the app was running.

Chrome

screen shot 2018-08-27 at 4 50 34 pm screen shot 2018-08-27 at 4 50 24 pm

Firefox

image image
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jasonLaster/source-map