Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4934

Fix formatWebpackMessages - fixes empty errors in console and overlay

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/DanProudfoot/next-error-handling into next Aug 28, 2018
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: DanProudfoot

The old version of this function looked for any mention of thread-loaded and then deleted everything thereafter - which most of the time included the actual stack trace that you wanted.

My fix just gets rid of the 3 lines from the threadLoaderIndex and leaves the rest in.

I feel this is a very naive fix, as I don't know the full breadth of errors to check against to know if I'm lopping anything else off at the wrong moment.....but it seems to work in my very limited testing thus far

Before: screen shot 2018-08-28 at 16 01 28

After: screen shot 2018-08-28 at 15 59 31

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/DanProudfoot/next-error-handling