Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4958

[react-scripts] template: given 100% width/height to react app container(<div id="root">)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ryota-murakami/feat/patch into next Sep 03, 2018
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: ryota-murakami

What's the Improve

Currently, react app container dom document.getElementById('root') has only contents' height.

Current

before

↑dom height not covered browser screen empty space.

But generally, I suppose majority users will remove existing App component stuff(code, logo, css), and then start write their own component. At that time, if document.getElementById('root') has fullscreen width/height by already, initial develop feel is quite good I think.

PR applied

after

Samary

I'm glad anyone in the maintainer has read through, If this change is attractive to many users, that's would be great to merge and I'd like to contribute to improving create-react-app😀

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ryota-murakami/feat/patch