Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5062

Upgrade svgr to v2 and disable Prettier & SVGO

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Timer/svg-upgrade into next Sep 21, 2018
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: Timer

Continuation of #4799 by @kopacki.

This updates svgr and disables Prettier / SVGO.

Prettier is disabled because it just increases compile-time latency, there's no true benefit here.

SVGO is disabled because there's no "safe defaults" that keep it useful IMO, and we don't apply optimizations to SVGs imported as URLs. Different optimization behavior based on how the SVG is imported would be confusing/unexpected to the user, especially during debugging.

If we go down the SVGO path, we'll probably only do it for Production and for both ReactComponents and URLs.

This PR will be a great first step.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Timer/svg-upgrade