Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5183

Test class properties

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Timer/test-class-properties into master Oct 01, 2018
  • Overview 2
  • Commits 9
  • Pipelines 0
  • Changes 7

Created by: Timer

Before #5182:

 FAIL  fixtures/smoke/issue-5176-flow-class-properties/index.test.js (128.315s)
  ● issue #5176 (flow class properties interaction) › passes tests
    Command failed: ./node_modules/.bin/react-scripts test --env node --ci
    FAIL src/App.test.js
      ✕ creates instance without (7ms)
      ● creates instance without
        TypeError: Cannot read property 'bind' of undefined
          1 | class App {
          2 |   constructor() {
        > 3 |     this.foo = this.foo.bind(this);
            |                         ^
          4 |   }
          5 |   foo: void => void;
          6 |   foo() {

After:

 PASS  fixtures/smoke/issue-5176-flow-class-properties/index.test.js (203.468s)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Timer/test-class-properties