Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5196

Format SVG React snapshots as <svg> tag with props

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge svg-snap into master Oct 01, 2018
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: gaearon

Fixes the issue in https://github.com/facebook/create-react-app/pull/5147#issuecomment-425768441.

We used to just emit filename for SVG snapshots when imported as React components. But that's not super useful and we forgot to change it before the release.

This prints it as an SVG tag instead, with any props passed in. But we don't render the inside.

Before and after:

-     logo.svg
+     <svg
+       className="lol"
+     >
+       logo.svg
+     </svg>

Closes #5191 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: svg-snap