Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5257

Fix `mjs` handling for graphql

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Timer/fix-mjs-support into master Oct 02, 2018
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 14

Created by: Timer

Fixes #5234 (closed). Closes #5235.

This pull request allows packages to import from dependencies who export a mjs file (instead of us giving a URL). It also ensures that a user who uses mjs in their application gets a file.

I'm really getting tired of all of these mjs hacks, because now we "sort of" support mjs. e.g.: If a user defines their module field in package.json as index.mjs and then explicitly import files with .mjs instead of being extensionless, we'll keep loading them.


I wonder if we can somehow tell webpack to not use module if the field is mjs? That would prevent this hack.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Timer/fix-mjs-support