Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5317

Remove unused require for getCacheIdentifier after ejecting

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/benbrandt/master into master Oct 05, 2018
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: benbrandt

I ejected a test project to take a look at the final webpack configs for some inspiration (our app has some custom needs, but I love looking at your configs for ideas!), and noticed that there was an unused import at the top of the file after ejecting.

Below is a screenshot after I ran the following from the root of the repo:

yarn create-react-app my-app
cd my-app
yarn eject

screen shot 2018-10-05 at 9 51 00 am

Let me know if you need anything else from me or if there is a better way to handle this!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/benbrandt/master