Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5407

add purpose comment

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ryota-murakami/add/comment into master 6 years ago
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: ryota-murakami

Overview

This is related to https://github.com/facebook/create-react-app/pull/5404. In the above PR, I was repeated same misunderstanding change of someone else. https://github.com/facebook/create-react-app/pull/4625

I think it's not make sense, so I added explicit comment, how does this look like? :grinning:

Activity

Please register or sign in to reply
  1. 11 Oct, 2018 2 commits
    • ryota-murakami's avatar
      add @see url · 6c897d2e
      ryota-murakami authored 6 years ago
      Unverified
      6c897d2e
    • ryota-murakami's avatar
      add purpose comment · 08c10f85
      ryota-murakami authored 6 years ago
      08c10f85
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: kahun/awesome-sysadmin!304
Source branch: github/fork/ryota-murakami/add/comment

Menu

Explore Projects Groups Snippets