Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5451

fix: add `sideEffects: false` to react-error-overlay

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/SimenB/patch-1 into master Oct 16, 2018
  • Overview 9
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: SimenB

This allows us to leave the import in the code, and webpack will still tree shake it out.

Verified by grepping for startReportingRuntimeErrors in the resulting bundle.

Note that this is usage outside of react-dev-utils.

Without this change, I need to use require and not import, and stick my require inside of an environment check.

Docs: https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/SimenB/patch-1