Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5575

add tests for named-asset-imports plugin

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/NShahri/named-asset-plugin-tests into master 6 years ago
  • Overview 5
  • Commits 8
  • Pipelines 0
  • Changes 3

Created by: NShahri

Some automation tests added to test named-asset-imports plugin

Hot to run

yarn test

OR

npm test
Approval is optional

Merged by (Jul 25, 2025 5:43am UTC)

Merge details

  • Changes merged into master with e2c4115d.
  • Deleted the source branch.

Activity


  • Administrator added CLA Signed label 6 years ago

    added CLA Signed label

  • Administrator mentioned in merge request !5573 (merged) 6 years ago

    mentioned in merge request !5573 (merged)

  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: iansu

    This is great. I suggested a few changes and we'll need to get this passing on CI.

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: NShahri

    Tests have been updated. please let me know if you think we need more tests to cover more cases. Thanks

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: Timer

    Can we make sure these tests run as part of e2e? Just add it somewhere in tasks/e2e-simple.sh.

  • Administrator added tag: internal label 6 years ago

    added tag: internal label

  • Administrator changed milestone to %2.1.1 6 years ago

    changed milestone to %2.1.1

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Merged by: iansu at 2018-10-31 20:33:02 UTC

  • Administrator closed 6 years ago

    closed

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: iansu

    Thanks!

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
CLA Signed tag: internal
2
CLA Signed tag: internal
    Assign labels
  • Manage project labels

Milestone
2.1.1
2.1.1
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!5575
Source branch: github/fork/NShahri/named-asset-plugin-tests

Menu

Explore Projects Groups Snippets