Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5686

Add empty mock for http2

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/kjin/h2 into master Nov 02, 2018
  • Overview 19
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: kjin

Following suit with #2600, this PR adds http2 as an empty module in webpack configs. I don't see http to the list, which suggests that this empty mock should probably be replaced with a browser-side implementation sometime in the future (I can add a TODO if needed).

See: https://github.com/grpc/grpc-node/issues/610 (Even though it turns out the module in question seems to not be meant for the client side, I believe the lack of this mock masked the real issue)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/kjin/h2