Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5816

Upgrade @svgr/webpack to 4.1.0

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/alaycock/master into master Nov 15, 2018
  • Overview 28
  • Commits 6
  • Pipelines 0
  • Changes 3

Created by: alaycock

I ran into an issue when upgrading to create-react-app 2 because @svgr/core@2.4.1 (a dependency of @svgr/webpack) had prettier as a dependency, which led to two different version of prettier being installed, which ended up causing linting issues when the two different versions of prettier ran (through yarn eslint vs yarn prettier). More details of my issue can be found here: https://github.com/prettier/eslint-plugin-prettier/issues/110

As of @svgr/core@4.0.0, prettier and svgo are no longer dependencies, and using it will prevent them from being installed, which would hopefully prevent prettier version conflicts in the future.

Neither prettier and svgo were being used in create-react-app anyway, so having them removed just removes a bit of node_modules bloat without cutting functionality.

To test, run create react app, and try out importing a SVG as a component with import { ReactComponent as Logo } from "./logo.svg";, and it should continue to work.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/alaycock/master