Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5823

Add default values to `file_ext` note

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/alaycock/patch-1 into master Nov 15, 2018
  • Overview 6
  • Commits 4
  • Pipelines 0
  • Changes 1

Created by: alaycock

The docs currently indicate that to enabling sass/scss support alongside flow can be done by adding the following to your .flowconfig.

[options] module.file_ext=.sass module.file_ext=.scss

Making that change is insufficient because defining values for module.file_ext overwrite the default values, and will prevent flow from reading from .js files, which prevents flow from functioning as expected.

You also need to add the following values, in order to prevent overwriting the defaults.

module.file_ext=.js module.file_ext=.jsx module.file_ext=.mjs module.file_ext=.json

I would be open documenting this in another way that is less verbose, but I think that there should be some indication that adding those values will overwrite the defaults.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/alaycock/patch-1