Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !584
An error occurred while fetching the assigned milestone of the selected merge_request.

Fix mocking assets with special characters in the file path

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/fson/fix-mocking-assets-with-special-chars into master 8 years ago
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: fson

The regexes in the Jest moduleNameMapper configs were a bit too strict, causing them to not pick up files with special characters like @ in the file path. Change them to match anything with the correct file extension.

Fixes #579 (closed).

Test plan:

  • Created a file named template/src/logo@2x.png.
  • Added import './logo@2x.png'; to App.js.
  • Ran npm test. Tests pass.
Approval is optional

Merge details

  • 1 commit and 1 merge commit will be added to main.
  • Source branch will not be deleted.

Activity


  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: vjeux

    Accepted. Feel free to merge it once you apply my comments :)

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: fson

    @vjeux Mind if I merge this without your suggestion? Jest doesn't work with the partial regex at the moment.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    @fson :thumbsup:

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Merged by: fson at 2016-09-10 16:56:43 UTC

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: vjeux

    Yeah go for it :)

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/fson/fix-mocking-assets-with-special-chars

Menu

Explore Projects Groups Snippets