Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5885

Add explanation of why we install everything as a dependency to the docs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/mikeattara/master into master 6 years ago
  • Overview 9
  • Commits 8
  • Pipelines 0
  • Changes 1

Created by: mikeattara

This solves issue #5805 (closed) @iansu and @Timer Kindly review my suggested solution Thanks

Approval is optional

Closed by (Jul 26, 2025 2:10am UTC)

Loading

Activity


  • Administrator added CLA Signed label 6 years ago

    added CLA Signed label

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: iansu

    I don't think this is the right location for this. It doesn't just apply to ejected apps. I think this page might be a better place for it: https://facebook.github.io/create-react-app/docs/installing-a-dependency

    Rather than just linking to the Stack Overflow answer I would like to incorporate the answer into the page. Maybe we add a section to the end of that page that explains why we install everything as a dependency.

  • Administrator added tag: documentation label 6 years ago

    added tag: documentation label

  • Administrator changed milestone to %2.1.x 6 years ago

    changed milestone to %2.1.x

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: mikeattara

    Alright. I will work on it @iansu

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: mikeattara

    @iansu When you install a dev dependency after using create react app puts it in devDependency. I think the issue is more with the eject script.

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: iansu

    It's true that none of these packages end up in package.json until after you eject so maybe this is the right place to document this. I would still like to explain why instead of just linking to Stack Overflow.

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: mikeattara

    Review: Commented

    @iansu Kindly let me know what you think. Thanks

  • Administrator mentioned in issue #5941 (closed) 6 years ago

    mentioned in issue #5941 (closed)

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: netlify[bot]

    Deploy preview for gallant-davinci-8f9bd9 failed.

    Built with commit 4be39ea0

    https://app.netlify.com/sites/gallant-davinci-8f9bd9/deploys/5c037024ec8a896b7b61a8c2

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: mikeattara

    @iansu Why is the build failing?

  • Administrator mentioned in merge request !6048 (closed) 6 years ago

    mentioned in merge request !6048 (closed)

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: mikeattara

    #6082 The updated edit to the docs

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: mikeattara

    I am closing this pr. Kindly check #6082 for the updated pr. Thanks

  • Administrator closed 6 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
CLA Signed tag: documentation
2
CLA Signed tag: documentation
    Assign labels
  • Manage project labels

Milestone
2.1.x
2.1.x
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!5885
Source branch: github/fork/mikeattara/master

Menu

Explore Projects Groups Snippets