Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !5926

progressive web app changes for lighthouse 100% score

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/dstroot/master into master Nov 30, 2018
  • Overview 12
  • Commits 2
  • Pipelines 0
  • Changes 10

Created by: dstroot

The project has done great work to create a progressive web app - however if you scaffold an app and deploy it "as is" you score low on the lighthouse test from Google. Why not make it awesome from the start! I know people have to change these files to make the app their own, but we should give them the best possible start. (of course they need to enable the service worker too).

screen shot 2018-11-29 at 5 00 58 pm

I needed to:

  • add two images and tweak the manifest.json file
  • add a robots.txt file
  • tweak the index.html file to add <meta name="description" content="Web site created using create-react-app">

That's it! BOOM 100%!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dstroot/master