Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6006

feat(xhtml): wrap generated script with cdata in InlineChunkHtmlPlugin

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/jean-smaug/inline-chunk-xhtml into master Dec 10, 2018
  • Overview 5
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: jean-smaug

Hi, The InlineChunkHtmlPlugin generate a script tag inside the index.html. So if we choose to use xhtml in the HtmlWebpackPlugin we got some troubles. The XML is bad formatted.

This PR check in the complier if there is an instance of HTMLWebpackPlugin and take the value of the xhtml key

cf : https://developer.mozilla.org/en-US/docs/Archive/Web/Writing_JavaScript_for_HTML

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jean-smaug/inline-chunk-xhtml