Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6022

TypeScript detection filtering 'node_modules'.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/springload/verify-no-typescript-filter-node-modules into master Dec 11, 2018
  • Overview 13
  • Commits 3
  • Pipelines 0
  • Changes 3

Created by: holloway

See #5947 (closed).

verifyNoTypeScript checks whether there are any TypeScript files in the project during the build, and this PR refines that logic by adding a Globby negation filter so that any node_modules under ./src is excluded from this logic.

Considering that verifyNoTypeScript has only existed since CRA 2.1 it seems very unlikely that anyone would depend on checking in a node_modules for TypeScript support, so this is a safe change.

Steps to reproduce this bug and to show that this PR fixes it:

  1. symlink ./src/anything to a directory outside the CRA project directory called anything.
  2. npm init the anything with its own package.json that depends on big-integer. big-integer is distributed on NPM with TypeScript files which will be present at ./src/anything/node_modules/big-integer/BigInteger.d.ts.
  3. Run yarn build and CRA ignores the TS and successfully builds.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/springload/verify-no-typescript-filter-node-modules