Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6060

Add environment variable to control image inlining threshold

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/peterbe/3437-environment-variable-to-disable-inlining-images into master Dec 18, 2018
  • Overview 8
  • Commits 7
  • Pipelines 0
  • Changes 3

Created by: peterbe

Fixes #3437 (closed)

I verified that this worked by editing the default application (packages/react-scripts/template/src/App.js) to reference a logo.png image that I made up. The file was 5,237 bytes and when I ran yarn run build the build/static/js/main.8204aa3b.chunk.js did contain the base64 string. Then, running IMAGE_INLINE_SIZE_LIMIT=5000 yarn run build this time the build/static/js/main.499ec856.chunk.js file was -5.27KB and the file build/static/media/logo.adb700a2.png existed.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/peterbe/3437-environment-variable-to-disable-inlining-images