Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6116

Set module resolution based on baseUrl in jsconfig/tsconfig.json

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/rovansteen/typescript-node-path into master Jan 03, 2019
  • Overview 17
  • Commits 34
  • Pipelines 0
  • Changes 19

Created by: rovansteen

Based on this thread on Twitter here is a PR to kickstart development/discussion on supporting absolute paths in Typescript via NODE_PATH so they work consistently between JS & TS.

Updated: Based on the discussion here: https://github.com/facebook/create-react-app/issues/5645#issuecomment-451170386 This attempts to unify the configuration by reading baseUrl from jsconfig.json / tsconfig.json.

🚧 This PR is still in progress

To do:

  • Add tests
  • Make sure paths are valid TypeScript
  • Add deprecation message to react-scripts start
  • Add documentation
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rovansteen/typescript-node-path