Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6249

Fix babel preset useESModules option

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/dallonf/patch-3 into master Jan 22, 2019
  • Overview 9
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: dallonf

Currently, useESModules only affects @babel/plugin-transform-runtime (so the compiled code does not reference ESM versions of @babel/runtime). This is somewhat misleading, since the resulting code will still contain ES Module syntax if the source uses it.

With this update, useESModule: false really means that the resulting code will not contain ES Module syntax.

I tested this locally in my company's fork of create-react-app.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dallonf/patch-3