Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6292

Add Node DNS module to empty mocks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Downchuck/patch-1 into master 6 years ago
  • Overview 6
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: Downchuck

DNS is required by some popular node.js modules; presently a require statement for DNS will throw an error if it is not wrapped in a try catch block.

Closes #6277 (closed).

Loading
Loading

Activity


  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

    If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: Downchuck

    This PR came from this conversation: http://metis.lti.cs.cmu.edu:8023/facebook/create-react-app/-/issues/6277

  • Administrator added CLA Signed label 6 years ago

    added CLA Signed label

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: Downchuck

    seems like this failed for unrelated reasons (build broken?)

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: mrmckeb

    Yes, this is not related to your work @Downchuck.

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Merged by: mrmckeb at 2019-02-05 07:38:53 UTC

  • Administrator closed 6 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: Go Enhancement: General
2
Client: Go Enhancement: General
    Assign labels
  • Manage project labels

Milestone
4.3.0
4.3.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: OpenAPITools/openapi-generator!5150
Source branch: github/fork/Downchuck/patch-1

Menu

Explore Projects Groups Snippets