Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6313

Update testMatch to also be compatible with Jest 24

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ngbrown-forks/patch-1 into master Jan 31, 2019
  • Overview 10
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: ngbrown

For people who try to use Jest 24, there is a different version of micromatch and it behaves differently. These changes should make it behave the same before and after changing Jest versions.

Without this change, Jest 24 will come up with no files to test.

I tested with npm run test -- --listTests on two projects, one with the default Jest 23 and another with the new Jest 24. In addition to numerous normally named test files had some special case files like src/.test.js, src/test.js, and src/somethingtest.js. Only the first two matched and the third one didn't; both pre-, and post- this change.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ngbrown-forks/patch-1