Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6367

Upgrade css-loader to 2.1.0

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/gnuletik/master into master Feb 08, 2019
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: gnuletik

A simple PR to upgrade css-loader to version 2.1.0. There is a bug with version 1.0.0 when importing a font with a hash at the end.

For example: This CSS

@font-face {
	font-family: "My Font";
	src: url("My Font.svg#Font Name") format("svg");
}

generates this:

@font-face {
	font-family: "My Font";
	src: url("/static/media/My Font.f84c8961.svg"#Font Name) format("svg");
}

(which is invalid)

This issue is fixed in css-loader v2.0.0. See the changelog here: https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md In this commit: https://github.com/webpack-contrib/css-loader/issues/803

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gnuletik/master