Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6656

Set baseUrl from jsconfig.json/tsconfig.json

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/rovansteen/typescript-base-url into master 6 years ago
  • Overview 39
  • Commits 22
  • Pipelines 0
  • Changes 29

Created by: rovansteen

This is a partial implementation of #6116. Because there are still a number of things that need to be figured about alias support I think it will be the best approach to add support for baseUrl first.

This will be a breaking change and removes support for setting NODE_PATH in .env file in favor of setting baseUrl in either jsconfig.json or tsconfig.json. It adds a warning to the start script to inform the user about this change if there is a NODE_PATH value in process.env.

This PR aims to add the existing behavior of resolving modules with absolute path that already exists in CRA but in a consistent manner for both TypeScript and JavaScript projects.

Since this is a breaking change it would be nice to get this in with 3.0. After that we can create another PR to add support for aliases (like @) since that would be a non-breaking change.

Checking approval status

Merged by (Jul 25, 2025 2:05am UTC)

Loading

Activity


  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator added CLA Signed label 6 years ago

    added CLA Signed label

  • Administrator mentioned in issue #6475 (closed) 6 years ago

    mentioned in issue #6475 (closed)

  • Administrator mentioned in merge request !6116 (closed) 6 years ago

    mentioned in merge request !6116 (closed)

  • Administrator added tag: new feature label 6 years ago

    added tag: new feature label

  • Administrator changed milestone to %3.0 6 years ago

    changed milestone to %3.0

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: zheeeng

    cheers, we neeeeeed it!

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: rovansteen

    Not sure if (or how) the tests on the CI are failing because of my changes :thinking:

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: eladmotola

    @rovansteen for the tests that failed on install: change modules.js : const chalk = require('react-dev-utils/chalk'); instead of - const chalk = require('chalk');

    I think it should fix it. I know its not much but its something I guess... btw thank you for that!

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: rovansteen

    @eladmotola thanks, that fixed the installs suite!

  • Administrator closed 6 years ago

    closed

  • Administrator reopened 6 years ago

    reopened

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: iansu

    Please resolve merge conflicts.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/rovansteen/typescript-base-url

Menu

Explore Projects Groups Snippets