Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6753

Add Service-Worker header to checkValidServiceWorker

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/darthmaim/feature/service-worker-header into master Apr 04, 2019
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: darthmaim

This PR adds the http header Service-Worker: script to the checkValidServiceWorker request in both serviceWorker templates, to match the spec on how to request a service worker.


See https://w3c.github.io/ServiceWorker/#update-algorithm:

To perform the fetch given request, run the following steps:

  1. Append Service-Worker/script to request’s header list.

And https://w3c.github.io/ServiceWorker/#service-worker-script-request:

An HTTP request to fetch a service worker's script resource will include the following header:

  • Service-Worker Indicates this request is a service worker's script resource request.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/darthmaim/feature/service-worker-header