Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6769

Update to core-js@3

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ianschmitz/corejs-update into master Apr 07, 2019
  • Overview 3
  • Commits 4
  • Pipelines 0
  • Changes 7

Created by: ianschmitz

This is a breaking change to our 3.0 alpha that deprecates the @babel/polyfill feature in favor of the recommended approach from the babel team as part of the babel 7.4.0 release. This adds a new react-app-polyfill/stable module that can be imported from src/index.js which will include polyfills for stable language features, and integrates nicely with @babel/preset-env which uses browserslist to only include polyfills for the target browsers.

Some more relevant info on this change: https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md#babel

Outstanding questions:

  • In the corejs@2 migration guide it says
    • If you are using @babel/plugin-transform-runtime, you need to use the corejs: 3 option

    • We currently have corejs: false so my sense is we can ignore this, but it would be helpful if someone with more knowledge of this plugin could chime in
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ianschmitz/corejs-update