Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !68

Dogfood our eslint config

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/keyz/dogfood-eslint-config into master 9 years ago
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: keyz

Implements #66 (closed). Also fixed a few errors.

@vjeux seems like checkNodeVersion() in global-cli/index.js is defined but not used -- should we fix this?

Compare
  • master (base)

and
  • latest version
    3bdd9945
    2 commits, 2 years ago

3 files
+ 11
- 1

    Preferences

    File browser
    Compare changes
scr‎ipts‎
ejec‎t.js‎ +1 -1
ta‎sks‎
e2e‎.sh‎ +3 -0
.eslin‎trc.js‎ +7 -0
scripts/eject.js
+ 1
- 1
  • View file @ 3bdd9945

  • Edit in single-file editor

  • Open in Web IDE


@@ -69,7 +69,7 @@ prompt('Are you sure you want to eject? This action is permanent. [y/N]', functi
files.forEach(function(file) {
console.log('Copying ' + file + ' to ' + hostPath);
content = fs
var content = fs
.readFileSync(path.join(selfPath, file), 'utf8')
// Remove license header from JS
.replace(/^\/\*\*(\*(?!\/)|[^*])*\*\//, '')
tasks/e2e.sh
+ 3
- 0
  • View file @ 3bdd9945

  • Edit in single-file editor

  • Open in Web IDE


@@ -30,6 +30,9 @@ perl -i -p0e 's/bundledDependencies.*?]/bundledDependencies": []/s' package.json
npm install
scripts_path=$PWD/`npm pack`
# lint
./node_modules/.bin/eslint --ignore-path .gitignore ./
# Pack CLI
cd global-cli
npm install
.eslintrc.js 0 → 100644
+ 7
- 0
  • View file @ 3bdd9945

  • Edit in single-file editor

  • Open in Web IDE

const clientESLintConfig = require('./config/eslint');
module.exports = Object.assign({}, clientESLintConfig, {
env: Object.assign({}, clientESLintConfig.env, {
node: true
})
});
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
CLA Signed
1
CLA Signed
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!68
Source branch: github/fork/keyz/dogfood-eslint-config

Menu

Explore Projects Groups Snippets