Skip to content
GitLab

Reads CDN_URL to populate webpack publicPath

Administrator requested to merge github/fork/SeeThruHead/CDN_URL into master

Created by: SeeThruHead

Previously we only allowed settings the pathname via the "homepage" key in package.json

Allows user to configure the full base URL via a $CDN_URL env variable

Development has the same behaviour.

Approval is optional

Merge details

  • 1 commit and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity

  • Administrator
    Administrator @root ·
    Author Contributor

    Created by: ghost

    Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

  • Administrator
    Administrator @root ·
    Author Contributor

    Created by: SeeThruHead

    Made this against an old non mono-repo, will open another

Please register or sign in to reply