Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !696

Update eslint-plugin-react and enable new rules

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/fson/update-eslint-plugin-react into master 8 years ago
  • Overview 10
  • Commits 2
  • Pipelines 0
  • Changes 4

Created by: fson

Some new rules had been added that are a good fit for this project. All of these are either already runtime warnings in React (no-danger-with-children, style-prop-object) or React features that are going to be deprecated in the future (no-find-dom-node). The new rules:

  • react/no-danger-with-children (yannickcr/eslint-plugin-react#710)
  • react/no-find-dom-node (yannickcr/eslint-plugin-react#678)
  • react/style-prop-object (yannickcr/eslint-plugin-react#715)
Compare
  • master (base)

and
  • latest version
    5cdc3570
    2 commits, 2 years ago

4 files
+ 5
- 3

    Preferences

    File browser
    Compare changes
pack‎ages‎
eslint-conf‎ig-react-app‎
inde‎x.js‎ +2 -0
packag‎e.json‎ +1 -1
react-‎scripts‎
packag‎e.json‎ +1 -1
packag‎e.json‎ +1 -1
packages/eslint-config-react-app/index.js
+ 2
- 0
  • View file @ 5cdc3570

  • Edit in single-file editor

  • Open in Web IDE


@@ -189,11 +189,13 @@ module.exports = {
}],
'react/jsx-uses-react': 'warn',
'react/jsx-uses-vars': 'warn',
'react/no-danger-with-children': 'warn',
'react/no-deprecated': 'warn',
'react/no-direct-mutation-state': 'warn',
'react/no-is-mounted': 'warn',
'react/react-in-jsx-scope': 'warn',
'react/require-render-return': 'warn',
'react/style-prop-object': 'warn',
// https://github.com/evcohen/eslint-plugin-jsx-a11y/tree/master/docs/rules
'jsx-a11y/aria-role': 'warn',
packages/eslint-config-react-app/package.json
+ 1
- 1
  • View file @ 5cdc3570

  • Edit in single-file editor

  • Open in Web IDE


@@ -16,6 +16,6 @@
"eslint-plugin-flowtype": "2.18.1",
"eslint-plugin-import": "1.12.0",
"eslint-plugin-jsx-a11y": "2.2.2",
"eslint-plugin-react": "5.2.2"
"eslint-plugin-react": "6.3.0"
}
}
packages/react-scripts/package.json
+ 1
- 1
  • View file @ 5cdc3570

  • Edit in single-file editor

  • Open in Web IDE


@@ -46,7 +46,7 @@
"eslint-plugin-flowtype": "2.18.1",
"eslint-plugin-import": "1.12.0",
"eslint-plugin-jsx-a11y": "2.2.2",
"eslint-plugin-react": "5.2.2",
"eslint-plugin-react": "6.3.0",
"extract-text-webpack-plugin": "1.0.1",
"file-loader": "0.9.0",
"filesize": "3.3.0",
package.json
+ 1
- 1
  • View file @ 5cdc3570

  • Edit in single-file editor

  • Open in Web IDE


@@ -16,7 +16,7 @@
"eslint-plugin-flowtype": "2.18.1",
"eslint-plugin-import": "1.12.0",
"eslint-plugin-jsx-a11y": "2.2.2",
"eslint-plugin-react": "5.2.2",
"eslint-plugin-react": "6.3.0",
"lerna": "2.0.0-beta.28"
}
}
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
CLA Signed
1
CLA Signed
    Assign labels
  • Manage project labels

Milestone
0.5.0
0.5.0
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!696
Source branch: github/fork/fson/update-eslint-plugin-react

Menu

Explore Projects Groups Snippets