Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6980

Stop hiding the column number of ESLint errors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/justingrant/patch-1 into master May 04, 2019
  • Overview 10
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: justingrant

Currently, CRA's npm start output only reports the line number of ESLint errors but hides the column numbers. This makes it harder for IDE users to leverage the time-saving features provided by IDEs like VSCode to deal with build errors:

  • devs can't one-click to navigate from the build error message to the exact spot in the code where the problem is.
  • the code editor won't show the little red sqiggly line under the exact spot in the code where the problem is.

This PR removes one line of code (originally introduced in #5174 last year) that removes column numbers from ESLint errors. Here's the current code. As you can see, it has no side effects-- it removes column numbers but doesn't do any other changes to the string. https://github.com/facebook/create-react-app/blob/4397d069d903c29927526d6fe4e7ba1b5edb136d/packages/react-dev-utils/formatWebpackMessages.js#L44-L46

Here's what existing errors look like:

./src/Calendar.tsx
  Line 19:  Unnecessary escape character: \.  no-useless-escape

Here's what errors will look like after this PR:

./src/Calendar.tsx
  Line 19:21:  Unnecessary escape character: \.  no-useless-escape
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/justingrant/patch-1