Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7036

Add ESLint extend support to eslint-loader

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge feature/eslint-extend into master May 12, 2019
  • Overview 23
  • Commits 1
  • Pipelines 0
  • Changes 5

Created by: mrmckeb

This allows users to extend the base ESLint config, so long as it is extending the react-app config.

Config in package.json Initially, this is limited to users that use package.json to configure ESLint. We can extend this later, but it will have performance implications as we would need to:

  • Find which config file the user is using.
  • Read that file, and confirm that it extends the react-app config.
  • Set that config to eslint-loader.

Eslint provides tooling to support this, but again, this will impact performance.

Users could work around this, by setting the following in package.json:

{
 "eslintConfig": {
   "extends": ["react-app", "./my-eslint-config.js"]
 }
}

Documentation Once this approach is approved, I'll update our ESLint documentation to outline usage.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/eslint-extend