Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7079

Adjust typescript-eslint to not warn about typedefs when used before defined

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/vincentjames501/eslint-ts-typedef-rule into master May 17, 2019
  • Overview 5
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: vincentjames501

The new ESLint TS rules are a little cumbersome for typedefs. We have 100s of places where we do things like the following as we like to have our types declared at the top of our files.

export type AppProps = ReturnType<typeof mapStateToProps> & typeof mapDispatchToProps;
export const mapStateToProps = (state: RootState) => ({  initialized: state.initialized });
export const mapDispatchToProps = { initialize };

Making the changes here in local eslint-config-react-app/index.js fixes the warnings for TS(X) files.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/vincentjames501/eslint-ts-typedef-rule