Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7208

Use correct babel transform for dynamic import in dependencies

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jamesknelson/patch-1 into master Jun 13, 2019
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: jamesknelson

The babel-plugin-transform-dynamic-import package is not specified in babel-preset-react-app's package.json. It appears that it was switched out with babel-plugin-dynamic-import-node in create.js here:

https://github.com/facebook/create-react-app/commit/52fcb23b0d3b80a3d79e3863a27372e83dded1e7

This commit updates it in dependencies.js too.

I ran into this while working on my SSR fork. The build script was failing before this commit, but is works correctly after the switch.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jamesknelson/patch-1