Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7260

Docs: remove an outdated TypeScript-related note

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/MidnightDesign/patch-1 into master 6 years ago
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: MidnightDesign

Maybe this was changed at some point in TypeScript.

Checking approval status

Merged by (Jul 25, 2025 3:50am UTC)

Loading

Activity


  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator requested review from @root 6 years ago

    requested review from @root

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

    If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

  • Administrator added CLA Signed label 6 years ago

    added CLA Signed label

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: iansu

    Do you have a reference to where this was fixed?

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: MidnightDesign

    Nope, I couldn't find anything. I just didn't get the error. You will get the error if you create a .ts file with no imports and no exports. But as soon as the file has at least one import (but no exports) it's gone. So I'm guessing this is something that behaved differently at some point.

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: stale[bot]

    This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

  • Administrator added stale label 6 years ago

    added stale label

  • Administrator added tag: documentation label and removed stale label 6 years ago

    added tag: documentation label and removed stale label

  • Administrator changed milestone to %3.1 6 years ago

    changed milestone to %3.1

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Merged by: iansu at 2019-07-22 16:14:57 UTC

  • Administrator closed 6 years ago

    closed

  • Administrator
    Administrator @root · 6 years ago
    Author Contributor

    Created by: iansu

    Thanks!

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
CLA Signed tag: documentation
2
CLA Signed tag: documentation
    Assign labels
  • Manage project labels

Milestone
3.1
3.1 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!7260
Source branch: github/fork/MidnightDesign/patch-1

Menu

Explore Projects Groups Snippets