Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7369

Respect app's eslintrc

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/chyipin/support-app-eslintrc into master Jul 14, 2019
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: chyipin

Allow react app to configure eslint without resorting to eject

Test Instructions

  1. npm link react-scripts globally
  2. create new create-react-app
  3. npm link react-scripts in new app
  4. modify eslintConfig in package.json as follows:
    "extends": [
      "eslint:recommended",
      "react-app"
    ]
  1. exercise the script, e.g.: npm run build
  2. verify output
./src/serviceWorker.js
  Line 44:  Unexpected console statement  no-console
  Line 72:  Unexpected console statement  no-console
  Line 85:  Unexpected console statement  no-console
  Line 97:   Unexpected console statement  no-console
  Line 123:  Unexpected console statement  no-console
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/chyipin/support-app-eslintrc