Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7421

Use defineProperty on global in setupTests.js

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tannerkrewson/patch-1 into master Jul 24, 2019
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: tannerkrewson

I tried to use this code example to mock the localStorage in a unit test. I was getting a "not a mock error", so I eventually ended up doing a console.log(localStorageMock == global.localStorage) directly after the line I removed in this PR, and it would return false. With this fix, it returns true and my tests are working.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tannerkrewson/patch-1