Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7472

Typescript init: suggest `jsx: "react"` in tsconfig

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/itsMapleLeaf/patch-1 into master Aug 03, 2019
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: itsMapleLeaf

Transpilation is done by Babel, which ignores the tsconfig, so this setting (or any tsconfig setting) doesn't affect compilation, only type checking.

Setting it to react raises a type error if react is not imported, and gives a quick fix to import react. The linter rule does not give a quick fix.

image

I've set it to suggest the value react instead of forcing it, because people might need to set it to something else in their project for whatever reason.

Verified that it works by cloning create-react-app from master, installing the local versions, and using it to compile a personal project. Setting "jsx": "react" does not affect the build size or content.

image

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/itsMapleLeaf/patch-1