Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7482

100% lighthouse score for progressive web app

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/dscanlan/ds_pwa_lighthouse into master Aug 06, 2019
  • Overview 6
  • Commits 2
  • Pipelines 0
  • Changes 10

Created by: dscanlan

This is a continuation for PR #5926

Testing a newly created PWA app currently scores low on the lighthouse test from google. With CRA doing a great job of scaffolding, these changes makes creating a PWA straight out of the box more straight forward.

Things to do for template and template-typescript:

  • add two images and updates the manifest.json file
  • add a robots.txt file
  • update the index.html file to add
    • <meta name="description" content="Web site created using create-react-app">
    • <link rel="apple-touch-icon" href="logo192.png">

Comments Resolved:

  • removed <main>
  • added comment in robots.txt
  • ran images through tinypng

PWA Lighthouse reports

App created without these changes

image

App created with lighthouse changes

image

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dscanlan/ds_pwa_lighthouse