Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7538

Explicitly checking that EXTEND_ESLINT is true

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/BrockWills/master into master Aug 15, 2019
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: BrockWills

The documentation for the new EXTEND_ESLINT env variable says it applies When set to true but the code only checks existence of the variable.

Setting EXTEND_ESLINT=false still enables extending eslint since process.env.EXTEND_ESLINT is technically set.

This PR just checks that process.env.EXTEND_ESLINT === 'true'

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/BrockWills/master