Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7571

Added back the crossOriginLoading 'anonymous' in config

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/jacob-j/patch-1 into master Aug 20, 2019
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: jacob-j

Not sure why this was removed, but it is necessary for production when target is web, which uses JSONP for loading on-demand chunks, by adding script tags.

This has been in the codebase previously, but seems to be removed. Check the old PR here: https://github.com/facebook/create-react-app/pull/1181

Any reason why it got removed?

Normal script elements pass minimal information to the window.onerror for scripts which do not pass the standard CORS checks. To allow error logging for sites which use a separate domain for static media, use the crossorigin attribute. See CORS settings attributes for a more descriptive explanation of its valid arguments.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jacob-j/patch-1