Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7716

Add template support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge feature/templates into master 5 years ago
  • Overview 9
  • Commits 4
  • Pipelines 0
  • Changes 157

Created by: mrmckeb

This is an updated version of #6514.

TODO:

  • Revert .gitignore change, as this is likely to cause confusion in future.
  • Improve support for old and forked react-scripts packages.
  • Fix failing tests.
  • Add documentation for this feature.
Loading
Loading

Activity


  • Administrator added CLA Signed label 5 years ago

    added CLA Signed label

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator removed review request for @root 5 years ago

    removed review request for @root

  • Administrator removed review request for @root 5 years ago

    removed review request for @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: mrmckeb

    @ianschmitz @iansu This PR is working locally, but I have a handful of tests to fix.

    It is ready for you to take a look at though, and you can test locally:

    node ../create-react-app/packages/create-react-app template-test \
      --template file:../create-react-app/packages/cra-template-typescript/ \
      --scripts-version file:../create-react-app/packages/react-scripts/

    e2e-kitchensink-eject was failing on Windows, as we use Git bash and $PWD. I've fixed that here.

    e2e-installs targets --scripts-version=1.0.17. This is failing due to the new template being incompatible with our internal testing template. The fix for this will also cover the real case the someone could use the latest create-react-app and a forked or outdated `react-scripts package.

  • Administrator added tag: new feature label 5 years ago

    added tag: new feature label

  • Administrator changed milestone to %3.2 5 years ago

    changed milestone to %3.2

  • Administrator mentioned in merge request !7791 5 years ago

    mentioned in merge request !7791

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator assigned to @root 5 years ago

    assigned to @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: iansu

    This is looking pretty good and I was able to test it locally with a custom template. We need to settle on a template prefix because it is going to be very hard to change later. I think cra-template- is okay. I don't like using cra but the alternative is way too long.

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: mrmckeb

    @ianschmitz Correct, everything works without a template for now. A custom script would need to accept the template though, otherwise it would just use the template it has.

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: andriijas

    First of all, awesome work! this will be a sweet addition to let others Kickstart apps even faster.

    I share the concern of @iansu - the project officially don't use the cra prefix anywhere (?) but on the other hand. Almost everyone just calls the project cra for short.

    Is "react-app-" to generic? (Clashes with react-app-rewired which is not a template)

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: mrmckeb

    @andriijas, we could use a different prefix, but I know a lot of the community use the CRA acronym. I think it's safe to use... create-react-app is very long, react-app is likely to conflict with existing packages, like react-app-template.

    This is the best we have I think...

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: andriijas

    @mrmckeb you are right. Let's just acknowledge the community acronym. Excellent work with this! Can't wait to see what kinds of templates the community will bring. Bootstrapping new react apps in 2020 will literally get you productive in seconds!

  • Administrator mentioned in merge request !7866 (closed) 5 years ago

    mentioned in merge request !7866 (closed)

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator closed 5 years ago

    closed

  • Administrator reopened 5 years ago

    reopened

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: iansu

    Something has gone horribly wrong with our CI here. Appveyor is in the list of checks and we got rid of that like a year ago.

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Merged by: iansu at 2019-10-24 22:17:42 UTC

  • Administrator closed 5 years ago

    closed

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: iansu

    Thanks! :heart:

  • Administrator mentioned in merge request !7881 (merged) 5 years ago

    mentioned in merge request !7881 (merged)

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
6.1.0
6.1.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: OpenAPITools/openapi-generator!12982
Source branch: feature/templates

Menu

Explore Projects Groups Snippets