Created by: mrmckeb
This is an updated version of #6514.
TODO:
-
Revert .gitignore change, as this is likely to cause confusion in future. -
Improve support for old and forked react-scripts packages. -
Fix failing tests. -
Add documentation for this feature.
Activity
added CLA Signed label
requested review from @root
requested review from @root
requested review from @root
removed review request for @root
removed review request for @root
requested review from @root
Created by: mrmckeb
@ianschmitz @iansu This PR is working locally, but I have a handful of tests to fix.
It is ready for you to take a look at though, and you can test locally:
node ../create-react-app/packages/create-react-app template-test \ --template file:../create-react-app/packages/cra-template-typescript/ \ --scripts-version file:../create-react-app/packages/react-scripts/
e2e-kitchensink-eject
was failing on Windows, as we use Git bash and $PWD. I've fixed that here.e2e-installs
targets--scripts-version=1.0.17
. This is failing due to the newtemplate
being incompatible with our internal testing template. The fix for this will also cover the real case the someone could use the latestcreate-react-app
and a forked or outdated `react-scripts package.added tag: new feature label
changed milestone to %3.2
mentioned in merge request !7791
requested review from @root
assigned to @root
requested review from @root
requested review from @root
Created by: iansu
This is looking pretty good and I was able to test it locally with a custom template. We need to settle on a template prefix because it is going to be very hard to change later. I think
cra-template-
is okay. I don't like usingcra
but the alternative is way too long.Created by: andriijas
First of all, awesome work! this will be a sweet addition to let others Kickstart apps even faster.
I share the concern of @iansu - the project officially don't use the cra prefix anywhere (?) but on the other hand. Almost everyone just calls the project cra for short.
Is "react-app-" to generic? (Clashes with react-app-rewired which is not a template)
Created by: mrmckeb
@andriijas, we could use a different prefix, but I know a lot of the community use the CRA acronym. I think it's safe to use...
create-react-app
is very long,react-app
is likely to conflict with existing packages, likereact-app-template
.This is the best we have I think...
mentioned in merge request !7866 (closed)
requested review from @root
mentioned in merge request !7881 (merged)