Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7790

Widen eslint-config-react-app peer dependency versions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/lukyth/lukyth/upgrade-eslint-plugin into master Oct 06, 2019
  • Overview 6
  • Commits 11
  • Pipelines 0
  • Changes 7

Created by: lukyth

Close #7759 (closed)

Description

From https://github.com/facebook/create-react-app/issues/7759, install eslint-config-react-app will produce a warning:

warning " > eslint-config-react-app@5.0.2" has incorrect peer dependency "eslint-plugin-flowtype@3.x".
warning " > eslint-config-react-app@5.0.2" has incorrect peer dependency "eslint-plugin-react-hooks@1.x".

They will be fixed by widening the peer dependency values for eslint-plugin-flowtype and eslint-plugin-react-hooks to include the latest major.

Acceptance criteria

  • eslint-plugin-flowtype in this repo should be 3.x || 4.x.
  • eslint-plugin-react-hooks in this repo should be 1.x || 2.x.
  • Installing eslint-config-react-app should not produce the warning above.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/lukyth/lukyth/upgrade-eslint-plugin