Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !79

Adds .gitignore file to default template

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/npverni/add-gitignore-to-template into master 9 years ago
  • Overview 15
  • Commits 4
  • Pipelines 0
  • Changes 2

Created by: npverni

Might be nice to give the users a .gitignore file to start with ala rails, ember, etc.

Approval is optional

Merged by (Jul 25, 2025 5:43am UTC)

Merge details

  • Changes merged into master with ae38faac.
  • Deleted the source branch.

Activity


  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: ghost

    Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: npverni

    done

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: gaearon

    Looks reasonable to me. @vjeux What do you think? Do/should we do this in RN too?

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: ghost

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: npverni

    Testing this a bit more, the .gitignore file is ending up as .npmignore in the created project due to https://github.com/npm/npm/issues/1862

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: vjeux

    This was something in my mental todo list. Happy with the concept (haven't reviewed the pull request yet)

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: jaredpalmer

    @ryanflorence did this in the react-project repo to handle this issue.

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: npverni

    Fix coming.

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: npverni

    This is working now. Ready for review. Thanks.

    screen shot 2016-07-22 at 2 08 21 pm

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: eanplatter

    Is there a specific advantage to programmatically creating the .gitignore file rather than just adding it to the template directory?

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: npverni

    Simplified the code and responded to questions.

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: vjeux

    Arg, okay so if you remove the / I'll merge it in, thanks!

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: npverni

    All set

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Merged by: vjeux at 2016-07-22 20:14:52 UTC

  • Administrator
    Administrator @root · 9 years ago
    Author Contributor

    Created by: vjeux

    Thanks!

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
CLA Signed
1
CLA Signed
    Assign labels
  • Manage project labels

Milestone
0.2.0
0.2.0
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!79
Source branch: github/fork/npverni/add-gitignore-to-template

Menu

Explore Projects Groups Snippets